🤖 Fix: DnD project order persistence bug #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem Project drag-and-drop order was not persisting across app restarts. The order would be correctly saved to localStorage but would be cleared on the next app launch. ## Root Cause Race condition during component initialization: 1. ProjectSidebar mounts with empty projects Map (projects load async) 2. projectOrder loads from localStorage (e.g., ["/a", "/b", "/c"]) 3. Normalization effect runs immediately with empty projects 4. normalizeOrder(order, emptyMap) returns [] - all paths filtered out 5. Empty array overwrites localStorage, losing the order ## Solution Skip normalization when projects.size === 0 to prevent clearing during initial load. Normalization still runs when: - Projects load from backend (projects.size > 0) - Projects are added/removed - User intentionally removes all projects ## Testing - Added unit tests for projectOrdering utility functions - Added integration tests documenting the bug scenario - Verified all existing tests still pass _Generated with `cmux`_
- Moved dnd-persistence tests into projectOrdering.test.ts (colocated) - Updated AGENTS.md with⚠️ CRITICAL marker for test colocation rule - Consolidated duplicate test scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Project drag-and-drop order was not persisting across app restarts. The order would be correctly saved to localStorage but would be cleared on the next app launch.
Root Cause
Race condition during component initialization:
ProjectSidebarmounts with empty projects Map (projects load async)projectOrderloads from localStorage (e.g.,["/a", "/b", "/c"])normalizeOrder(order, emptyMap)returns[]- all paths filtered outSolution
Skip normalization when
projects.size === 0to prevent clearing during initial load. Normalization still runs when:Testing
Generated with
cmux